-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Add extra safety measures, better documentation, better logging, and a separate test to avoid invalid notebook states #153
Conversation
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 79.75% 77.01% -2.74%
==========================================
Files 17 17
Lines 800 805 +5
==========================================
- Hits 638 620 -18
- Misses 162 185 +23
Continue to review full report at Codecov.
|
Ohhhhhhhh. I can't trigger the SystemExit, because the CLI uses the guides directory as an nbproject folder... That shouldn't be the case! This is what the example project is for. 😅 We need a controlled test environment in the guides directory. |
We need to restore these parts of the code base by constructing a clean isolated test case for the CLI in the @Koncopd, happy to discuss this! |
Add extra safety with a SystemExit and much clearer logging, stratified by interactive vs. non-interactive.
Jupyter Notebook:
VS Code:
Jupyter Lab: