-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several small changes and tweaks for patch release #1383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in.micelle-rigid should be in.micelle.rigid for consistency,
the data.micelle file does not have image flags but just shifting some atoms outside the box?
done
this is in accord with the documentation. for PBC those are created after reading. only with fixed boundaries, the atoms outside the box would be discarded. |
Summary
Final set of small changes for the upcoming patch release.
Related Issues
supersedes and closes #1381
Author(s)
Axel Kohlmeyer (Temple U)
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
yes.
Implementation Notes
Individual changes are:
git -C
to be the toplevel source dir instead of the .git folder to avoid spuriousmodified
flag ingit describe
.Post Submission Checklist
Please check the fields below as they are completed after the pull request has been submitted. Delete lines that don't apply