Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collected small updates and bugfixes #2227

Merged
merged 25 commits into from
Jul 11, 2020
Merged

Collected small updates and bugfixes #2227

merged 25 commits into from
Jul 11, 2020

Conversation

akohlmey
Copy link
Member

@akohlmey akohlmey commented Jul 11, 2020 •
edited
Loading

Summary

This pull request collects several small fixes and updates that were found while testing the changes in PRs #2218 and #2219

Related Issues

Closes #2215
Closes #2225

Author(s)

Axel Kohlmeyer, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

No known issues.

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.
  • A package specific README file has been included or updated

@akohlmey
refactor tester
d320002
@akohlmey
add missing symlink
f8321d7
@akohlmey
add prototypes for exception handling functions
40e59b2
@akohlmey
avoid exception when having a command fail due to an empty string
d0c5442
@akohlmey
fix typo
6f775f6
@akohlmey
small tweak
17d59a4
@akohlmey
use parenthesis to correct precedence
e6a8f3c
@akohlmey
synchronize exception based and non-exception based code paths
ed452c3
@akohlmey
avoid illegal free()
207232c
@akohlmey
avoid googletest stalling on exit tests when using OpenMPI
8eb7791
@akohlmey
several fixes to address issues detected by valgrind
26e2185 
- make sure g_ewald_6 is not accessed uninitialized
- fix memory leak
- do not override g_ewald_6 if it is explicitly set
@akohlmey
use fmtlib for writing data file coefficients. use mixed coefficients…
d4da995 
… for PairIJCoeffs
@akohlmey
some more OpenMPI suppressions
4b2c1f5
@akohlmey
avoid memory leak in pair style sw/intel
b49f0a6
@akohlmey
fix typo
510d527
@akohlmey
fix memory leak in pair style sw/intel for good
4778887
@akohlmey
ewald_order needs to be saved in restart
9fe0b1c
@akohlmey
fix initialition issue
c6dc8b5
@akohlmey
more OpenMPI suppressions
8359a43
@akohlmey
zero out additionally allocated struct Param storage
e42342f
@akohlmey
add suppressions for googletest
b3060bc
@akohlmey
adjust regex for removed styles to correctly handle command styles
cd0b034
@akohlmey
count total number of styles including aliases, suffixes, and undocum…
f307d7f 
…ented
@akohlmey
add space for terminating NULL byte in MPIIO dump styles.
f969d9a 
closes lammps#2225
@akohlmey akohlmey added this to the Stable Release Summer 2020 milestone Jul 11, 2020
@akohlmey akohlmey self-assigned this Jul 11, 2020
@akohlmey
may not use pair_style kim before box is defined
83291fd 
NOTE: this will not happen when the kim_init and kim_interactions commands are used.
@akohlmey akohlmey merged commit 284b161 into lammps:master Jul 11, 2020
@akohlmey akohlmey deleted the collected-small-fixes branch July 11, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjplimp sjplimp sjplimp approved these changes

@rbberger rbberger Awaiting requested review from rbberger

Assignees

@akohlmey akohlmey

Labels
bugfix build_system documentation maintenance tools
Projects
None yet
Milestone
Stable Release Fall 2020
Development

Successfully merging this pull request may close these issues.

Buffer overflow with 'dump */mpiio' and OpenMP [BUG] Cannot use pair style kim before box is created
2 participants
@akohlmey @sjplimp