Create logic in parsing KIM Simulator Models to treat periodic vs. aperiodic simulations differently #2442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to kim_interactions to generalize the interpreter for smspec.edn to allow for different variants of the model commands for aperiodic vs periodic simulations
Summary
OpenKIM simulator models (SMs) work by creating appropriate input commands at runtime and sending them to the LAMMPS input parser. With this extension, we allow for an SM to send different commands depending on whether the simulation being run is periodic or aperiodic (thereby using, or not, kspace features as appropriate for example)
Related Issue(s)
None.
Author(s)
Ron Miller, Carleton University
Ryan Elliott, U Minnesota
Ellad Tadmor, U Minnesota
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
fully backward compatible.
Implementation Notes
confined to the KIM package. No other features should be affected.
Post Submission Checklist
Further Information, Files, and Links