Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create logic in parsing KIM Simulator Models to treat periodic vs. aperiodic simulations differently #2442

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

ProfessorMiller
Copy link
Contributor

@ProfessorMiller ProfessorMiller commented Oct 22, 2020

Updates to kim_interactions to generalize the interpreter for smspec.edn to allow for different variants of the model commands for aperiodic vs periodic simulations

Summary

OpenKIM simulator models (SMs) work by creating appropriate input commands at runtime and sending them to the LAMMPS input parser. With this extension, we allow for an SM to send different commands depending on whether the simulation being run is periodic or aperiodic (thereby using, or not, kspace features as appropriate for example)

Related Issue(s)

None.

Author(s)

Ron Miller, Carleton University
Ryan Elliott, U Minnesota
Ellad Tadmor, U Minnesota

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

fully backward compatible.

Implementation Notes

confined to the KIM package. No other features should be affected.

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

…(logic to allow variants for aperiodic vs periodic simulations
@ellio167 ellio167 self-requested a review October 23, 2020 16:43
@akohlmey akohlmey self-assigned this Oct 27, 2020
@akohlmey akohlmey requested a review from sjplimp October 27, 2020 04:40
@akohlmey akohlmey added this to the Stable Release Fall 2020 milestone Oct 27, 2020
@akohlmey akohlmey merged commit b8e84d0 into lammps:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants