-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collected small changes and fixes #2678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akohlmey
added
refactor
test_for_regression
Enable to trigger regression tests
test_runs
Enable to trigger run tests
and removed
test_for_regression
Enable to trigger regression tests
test_runs
Enable to trigger run tests
labels
Mar 27, 2021
akohlmey
added
test_for_regression
Enable to trigger regression tests
test_runs
Enable to trigger run tests
and removed
test_for_regression
Enable to trigger regression tests
labels
Mar 29, 2021
akohlmey
added
test_for_regression
Enable to trigger regression tests
test_runs
Enable to trigger run tests
and removed
test_for_regression
Enable to trigger regression tests
test_runs
Enable to trigger run tests
labels
Mar 29, 2021
akohlmey
requested review from
giacomofiorin,
junghans,
ndtrung81,
rbberger,
sjplimp and
stanmoore1
as code owners
March 29, 2021 13:17
sjplimp
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request combines a few bug fixes and multiple local/simple refactoring changes to increase code reuse.
In total this PR removes over 2200 lines of code by simplification or code reuse.
Related Issue(s)
Fixes #2676
Author(s)
Axel Kohlmeyer, Temple U
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
No known issues.
Implementation Notes
This PR contains the following individual changes:
cosine/periodic
cosine/squared
as used in DREIDINGPost Submission Checklist