Split internal fix STORE command into fix STORE/GLOBAL and fix STORE/PERATOM #3379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is next to no shared code between global and per-atom storage mode of fix STORE. In addition we need if statements to discriminate which mode is in use and some of the indexing variable use was inconsistent between the two modes.
Splitting the fix into two fixes STORE/GLOBAL and STORE/PERATOM simplifies the respective implementations and maintenance. For consistency, fix STORE_LOCAL is renamed to fix STORE/LOCAL.
This also fixes a minor related issue in the bond style bpm/rotational documentation. Thanks to @hammondkd for reporting.
Author(s)
Axel Kohlmeyer, Temple U
Licensing
By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).
Backward Compatibility
This is an internal-only command and all internal uses have been updated. External code using fix STORE will need to be updated. The section of the developer information related to porting external LAMMPS code has been updated accordingly.
Post Submission Checklist