Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: add comparisonParams to BodyMatches for Json and XML #117

Merged
merged 1 commit into from
May 11, 2022
Merged

new: add comparisonParams to BodyMatches for Json and XML #117

merged 1 commit into from
May 11, 2022

Conversation

lansfy
Copy link
Contributor

@lansfy lansfy commented Jan 7, 2022 •
edited
Loading 

            - kind: bodyMatchesJSON
              comparisonParams:
                disallowExtraFields: true
              body: >
                {
                  "some_field": "some_value"
                }

@nikgalushko
Copy link

Thank you for your contribution. Please add tests and update the documentation.

nikgalushko
nikgalushko reviewed Jan 10, 2022
View reviewed changes
mocks/loader.go
for key, val := range values {
skey, ok := key.(string)
if !ok {
return params, errors.New("`comparisonParams` has non-string key")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may add a key name to the error.

@nikgalushko nikgalushko added the enhancement New feature or request label Jan 10, 2022
@Cdayz Cdayz merged commit aa65d1d into lamoda:master May 11, 2022
@github-actions
Copy link

🚀 PR was released in v1.14.1 🚀

@lansfy lansfy mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikgalushko nikgalushko nikgalushko left review comments

@keyclaim keyclaim keyclaim approved these changes

@Cdayz Cdayz Cdayz approved these changes

@maximdanilchenko maximdanilchenko Awaiting requested review from maximdanilchenko

@vitkarpenko vitkarpenko Awaiting requested review from vitkarpenko

Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lansfy @nikgalushko @keyclaim @Cdayz