Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community-build : illegal file name in project Cask #11710

Closed
michelou opened this issue Mar 12, 2021 · 3 comments · Fixed by #11826
Closed

community-build : illegal file name in project Cask #11710

michelou opened this issue Mar 12, 2021 · 3 comments · Fixed by #11826

Comments

@michelou
Copy link
Collaborator

michelou commented Mar 12, 2021

Assignee : @lihaoyi

The addition of the Cask project to the community build prevents git operations on a Windows machine (see line 229 in file communitybuild/projects.scala.

C:\opt\Git-2.30.2\mingw64\bin\git.exe submodule update --init --recursive --jobs 7
error: invalid path 'docs/pages/1 - Cask: a Scala HTTP micro-framework.md'
Unable to checkout '93c27abe583c2b804e5ce66271440789fca0581a' in submodule path 'community-build/community-projects/cask'

Directory cask/docs/pages/ contains 3 Markdown files.
The name of the first file, namely 1 - Cask: a Scala HTTP micro-framework.md, is illegal on Windows because it contains a colon character.

PS. Furthermore one should avoid spaces in file names (e.g. Is it problematic to include spaces in file names?).

@eed3si9n
Copy link
Member

Why am I assigned this?

@michelou
Copy link
Collaborator Author

michelou commented Mar 13, 2021

Why am I assigned this?

@eed3si9n Sorry. My mistake.

@jodersky
Copy link
Member

That's annoying indeed. I think it can be fixed upstream without an issue, but if this is super high prio, you can just remove the file from the community build for now.

jodersky pushed a commit to jodersky/dotty that referenced this issue Mar 20, 2021
michelou pushed a commit to michelou/dotty that referenced this issue Mar 20, 2021
michelou pushed a commit to michelou/dotty that referenced this issue Mar 22, 2021
michelou pushed a commit to michelou/dotty that referenced this issue Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants