Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify quoted.report and reflect.Reporting #10474

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Unify quoted.report and reflect.Reporting #10474

merged 1 commit into from
Nov 26, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 24, 2020 •
edited
Loading

  • Make a single reflect.report that contains all reporting functionality
  • Make message parameters by-value
  • Add missing throwError overloads

[test_sbt]

@nicolasstucki nicolasstucki self-assigned this Nov 24, 2020
@nicolasstucki nicolasstucki force-pushed the unify-quoted-reporters branch 2 times, most recently from 22ba037 to 6357584 Compare November 25, 2020 07:50
@nicolasstucki nicolasstucki marked this pull request as ready for review November 25, 2020 08:51
liufengyun
liufengyun approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

library/src/scala/quoted/Quotes.scala Outdated Show resolved Hide resolved
@nicolasstucki
Unify quoted.report and reflect.Reporting
81991f6 
Make a single `reflect.report` that contains all reporting functionality.
Also, make message parameters by-value.
@nicolasstucki nicolasstucki merged commit 62b8b8e into scala:master Nov 26, 2020
@nicolasstucki nicolasstucki deleted the unify-quoted-reporters branch November 26, 2020 06:41
@griggt griggt mentioned this pull request Nov 27, 2020
Closed
@nicolasstucki nicolasstucki mentioned this pull request Nov 27, 2020
Merged
@nicolasstucki nicolasstucki added the release-notes Should be mentioned in the release notes label Dec 2, 2020
@deusaquilus
Copy link
Contributor

I actually really liked quoted.report since I don't want to always have a Quotes instance around. This almost feels like we're going in circles back to ctx.throwError.

@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
release-notes Should be mentioned in the release notes
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasstucki @deusaquilus @liufengyun @Kordyjan