Remove compiletime.Widen #11569
Merged
Remove compiletime.Widen #11569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Mar 1, 2021
| val res = | ||
| inline erasedValue[T] match | ||
| case _: EmptyTuple => EmptyTuple | ||
| case _: (t *: ts) => constValue[t] *: constValueTuple[ts] | ||
| end match | ||
| res.asInstanceOf[Widen[T]] | ||
| res.asInstanceOf[T] |
There was a problem hiding this comment.
Is that cast actually still needed?
There was a problem hiding this comment.
Yes, before inlining the type of res is Tuple.
There was a problem hiding this comment.
Can these two be implemented in terms of map, which already deals with casting it.
There was a problem hiding this comment.
The issue is that we do not have a tuple on which we could call map.
This comment has been minimized.
This comment has been minimized.
nicolasstucki
force-pushed
the
remove-compiletime-Widen
branch
from
70dd456
to
859cdd2
Compare
nicolasstucki
changed the title
vincenzobaz
added a commit
to scalacenter/scio
that referenced
this pull request
Apr 7, 2021
vincenzobaz
added a commit
to scalacenter/scio
that referenced
this pull request
Apr 7, 2021
MaximeKjaer
pushed a commit
to scalacenter/scio
that referenced
this pull request
Apr 12, 2021
MaximeKjaer
pushed a commit
to scalacenter/scio
that referenced
this pull request
Apr 19, 2021
MaximeKjaer
pushed a commit
to scalacenter/scio
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a workaround to some limitations of type inference.