Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Function25 on top of #1413. #1422

Merged
merged 1 commit into from Jul 31, 2016
Merged

Conversation

nicolasstucki
Copy link
Contributor

Review by @odersky .

There is one case in scalacheck where there are 3 captured parameters on top of the explicit 22.

@DarkDimius
Copy link
Member

Adding functions by one does not scale. Can we make functions over 22
arguments be created lazily and add a temporary check in refchecks that
people do not use them with a nice error message?

Addionally, it would be great to add a postcondition to lambdalift that
those functions do not survive.

On 28 July 2016 11:46:41 am Nicolas Stucki notifications@github.com wrote:

Review by @odersky .

There is one case in scalacheck where there are 3 captured parameters on
top of the explicit 22.
You can view, comment on, or merge this pull request online at:

#1422

-- Commit Summary --

-- File Changes --

M src/dotty/tools/dotc/core/Definitions.scala (4)
A src/scala/Function25.scala (21)

-- Patch Links --

https://github.com/lampepfl/dotty/pull/1422.patch
https://github.com/lampepfl/dotty/pull/1422.diff


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#1422

@odersky
Copy link
Contributor

odersky commented Jul 28, 2016

I agree that adding functions by one does not scale. But it's a temporary hack anyway. So I'd say let's add two more as a quick fix before we do the real one. @nicolasstucki can you do this please?

@nicolasstucki
Copy link
Contributor Author

I added functions up to 30, with this we can capture up to 8 additional parameters.

Has someone started looking into removing the parameter number limitation yet?

@odersky
Copy link
Contributor

odersky commented Jul 28, 2016

LGTM, thanks!

Nobody has started working on the general problem yet. I thought Olivier Blancpain could have a go at it when he starts in September.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants