Fix #1385: Temporarily lift 22 limit for functions #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +12,13 @@ import collection.mutable | |||
| import scala.reflect.api.{ Universe => ApiUniverse } | |||
|
|
|||
| object Definitions { | |||
| val MaxFunctionArity, MaxTupleArity = 22 | |||
| val MaxTupleArity, MaxAbstractFunctionArity = 22 | |||
| val MaxFunctionArity = 24 | |||
There was a problem hiding this comment.
MaxFunctionArity should be 44 as documented below.
There was a problem hiding this comment.
Actually it is the doc that is off.
|
That is all. |
| @@ -0,0 +1,7 @@ | |||
| object Test { | |||
| def foo22[T](c1:T, c2:T, c3:T, c4:T, c5:T, c6:T, c7:T, c8:T, c9:T, c10:T, c11:T, c12:T, c13:T, c14:T, c15:T, c16:T, c17:T, c18:T, c19:T, c20:T, c21:T, c22:T): Int => T = { | |||
| (a: Int) => { // This labda ends with 23 parameters (c1 to c22 and a) | |||
|
LGTM |
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jul 28, 2016
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jul 28, 2016
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jul 28, 2016
odersky
added a commit
that referenced
this pull request
Jul 31, 2016
Add Function25 on top of #1413.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanatiions in comment in Definitions. Review by @nicolasstucki.