Fix #13523: Survive missing Java inner annotation classfiles #15094
Conversation
There was a problem hiding this comment.
So this is really Tom's fix and I served as reviewer / sounding board. We looked at Guillaume's previous fix together, and then he walked me through this fix, and we discussed it from every angle either of us could think of. Conclusion: LGTM 👍
(Minor point, I did suggest that the test be in a package rather than in the empty package, since the empty package is a special case, and to be sure that it still worked in the presence of a package prefix.)
Might be good to have one more reviewer, probably @smarter since this is so closely related to his previous fix (#9096).
| val result = atPhase(typerPhase)(getMember(owner, innerName.toTypeName)) | ||
| val result = owner.denot.infoOrCompleter match | ||
| case _: StubInfo if hasAnnotation(entry.jflags) => | ||
| requiredClass(innerName.toTypeName) |
There was a problem hiding this comment.
Since this is not obvious, could you add a comment explaining why this is needed and pointing the reader to the test case?
Co-authored-by: Seth Tisue <seth@tisue.net>
Co-authored-by: Seth Tisue seth@tisue.net
Fixes #13523