Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #17435: A simpler fix #17436

Merged
merged 2 commits into from
May 19, 2023
Merged

Fix #17435: A simpler fix #17436

merged 2 commits into from
May 19, 2023

Conversation

liufengyun
Copy link
Contributor

Fix #17435: A simpler fix for #17382

@liufengyun
Fix scala#17435: A simpler fix
c9dc8e7 
This commit replaces scala#17382 with a simpler fix.
@liufengyun liufengyun marked this pull request as ready for review May 9, 2023 06:38
@nicolasstucki
Copy link
Contributor

I started a test for this fix in community-build3.

@nicolasstucki nicolasstucki self-assigned this May 12, 2023
@nicolasstucki
Copy link
Contributor

It seems the test failed with the same stack overflow.

@nicolasstucki
Copy link
Contributor

@liufengyun is this change something we should merge regardless of #17435?

@liufengyun
Copy link
Contributor Author

@nicolasstucki Thank you. From the logs, it seems the community build is testing the master, not this PR. /cc: @WojciechMazur

@WojciechMazur
Copy link
Contributor

WojciechMazur commented May 15, 2023 •
edited
Loading

I've set up a build just for jsoniter here: https://github.com/VirtusLab/community-build3/actions/runs/4980965924/jobs/8914559544
Maybe the custom repo/branch was not set up

For that particular project, it seems to fix the build. Should we test this PR against other projects?

@liufengyun
Copy link
Contributor Author

Thank you @WojciechMazur .

Should we test this PR against other projects?

That would be nice. Maybe only those projects that are green on master, so that it'll be easy to tell whether there is a regression from this PR.

@nicolasstucki
Copy link
Contributor

The tests passed in https://github.com/VirtusLab/community-build3/actions/runs/4980965924/jobs/8914559544

@nicolasstucki nicolasstucki merged commit b67e269 into scala:main May 19, 2023
@nicolasstucki nicolasstucki deleted the fix-17435 branch May 19, 2023 14:37
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@nicolasstucki nicolasstucki nicolasstucki approved these changes

@WojciechMazur WojciechMazur Awaiting requested review from WojciechMazur

Assignees

@liufengyun liufengyun

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

Infinite loop in TypeTestsCasts
5 participants
@liufengyun @nicolasstucki @WojciechMazur @dwijnand @Kordyjan