Eliminate FromJavaObject from TASTy of Java sources #19259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
added
the
needs-minor-release
|
We are also considering dropping the "fake" constructor added to all java classes by the parser public class Foo {
private Foo(scala.Unit x$1) {} // COMPILER GENERATED
}also the fake "default constructor" inserted for an empty java class should have a body public class B {} |
sjrd
approved these changes
Dec 14, 2023
bishabosha
force-pushed
the
stabilise-java-tasty
branch
2 times, most recently
from
04d6598
to
e1d9ea4
Compare
|
@sjrd no idea why but the spec keeps failing to build due to ruby gem errors unrelated to this PR |
introduce SPLITCLAUSE at the end of the template parents, if present, then there is no primary constructor. We assert that we have the JAVAattr and reconstruct the fake primary constructor to satisfy the compiler.
Also do not make a fake param accessor for the fake param of the fake constructor.
bishabosha
force-pushed
the
stabilise-java-tasty
branch
from
e1d9ea4
to
67e94be
Compare
sjrd
approved these changes
Dec 15, 2023
|
ignoring the weird spec CI error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not pickle type references to
FromJavaObjectfor Java sources, instead insert them at unpickling time. This ensures consistency ofIDENTtpt(whereObjectis given an explicit type) andSELECTtptwhere the type has to be resolved from just the nameObject.modify
-Ytest-picklerto check for the presence ofFromJavaObjectAlso we compare unpicking Java signatures from TASTy to unpicking from class files to ensure consistency
fixes #19246