Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consistent JAVAattr tasty output #19246

Closed
bishabosha opened this issue Dec 11, 2023 · 0 comments · Fixed by #19259
Closed

Ensure consistent JAVAattr tasty output #19246

bishabosha opened this issue Dec 11, 2023 · 0 comments · Fixed by #19259
Assignees
@bishabosha
Labels
area:tasty-format issues relating to TASTy as a portable standard itype:enhancement needs-minor-release This PR cannot be merged until the next minor release
Milestone
3.4.0

Comments

@bishabosha
Copy link
Member

bishabosha commented Dec 11, 2023 •
edited
Loading

Compiler version

3.4.0-RC1-bin-SNAPSHOT

Minimized code

Before we freeze 28.4.0 TASTy, we should ensure that JAVAattr output is consistent.

Currently <FromJavaObject> does appear in TASTy generated for Java sources. We should ensure that it is consistently applied (i.e. there is not a mix of java.lang.Object and <FromJavaObject>)
@bishabosha bishabosha added itype:enhancement area:tasty-format issues relating to TASTy as a portable standard needs-minor-release This PR cannot be merged until the next minor release labels Dec 11, 2023
@bishabosha bishabosha added this to the 3.4.0 milestone Dec 11, 2023
@bishabosha bishabosha mentioned this issue Dec 13, 2023
Merged
bishabosha added a commit that referenced this issue Dec 15, 2023
@bishabosha
Eliminate FromJavaObject from TASTy of Java sources (#19259)
08572ee 
Do not pickle type references to `FromJavaObject` for Java sources,
instead insert them at unpickling time. This ensures consistency of
`IDENTtpt` (where `Object` is given an explicit type) and `SELECTtpt`
where the type has to be resolved from just the name `Object`.

modify `-Ytest-pickler` to check for the presence of `FromJavaObject`

Also we compare unpicking Java signatures from TASTy to unpicking from
class files to ensure consistency

fixes #19246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bishabosha bishabosha

Labels
area:tasty-format issues relating to TASTy as a portable standard itype:enhancement needs-minor-release This PR cannot be merged until the next minor release
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Eliminate FromJavaObject from TASTy of Java sources dotty-staging/dotty
1 participant
@bishabosha