Fix #2212: Avoid imports in the wrong namespace #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't issue an error if when considering a named import that refers to a valoe or type which does not exist. Instead, disregard the import an continue.
olafurpg
approved these changes
Apr 11, 2017
There was a problem hiding this comment.
LGTM 👍 I've added a note (dotty-staging/squants#3) to revert the workaround for this issue in the squants fork of the community build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't issue an error when considering a named import that
refers to a value or type which does not exist. Instead, disregard
the import and continue.