Upgrade to sbt 1 #3872
Merged
Upgrade to sbt 1 #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft at fixing the sbt bridge to match the Zinc 1.0 API.
After sbt/zinc#101, SimpleType simply doesn't exist anymore.
Some of sbt's callbacks need the full name of the class that can only be accessed during the first step of the GenBCode pipeline. So we call the callbacks in the first step, generating at the same time the class files, and keep those files through the whole pipeline so the last step can write the bytecode in them.
A FileConflictException may occure when creating a class file. Add check for this error and refactor a bit of code around it.
That test depended on NameHashing being disabled, which is no longer supported with Zinc 1.0
It isn't passing in sbt/sbt either. See sbt/sbt#3691
It has been changed in sbt/zinc.
allanrenucci
force-pushed
the
topic/sbt1
branch
from
61dbba5
to
0495c85
Compare
This release contains a fix allowing us to remove the workaround added a few commits earlier.
sbt/zinc@9397b6a#diff-ea135f2f26f43e40ff045089da221e1e introduced a new constructor for ScalaInstance and deprecated the old one. We use the new one but don't call it with the proper arguments. It shouldn't matter though as the enw constructor was introduced to fix an issue with `sbt run` that only occurs when `(fork in run) := false`.
allanrenucci
force-pushed
the
topic/sbt1
branch
from
172b82c
to
05fd47e
Compare
allanrenucci
force-pushed
the
topic/sbt1
branch
from
05fd47e
to
67ff1f2
Compare
assertEquals(expected, found)
allanrenucci
force-pushed
the
topic/sbt1
branch
from
5c4dead
to
7a99074
Compare
|
Benchmarks work without problem 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #3441.
Reviews still need to be addressedUnintentionally closed #3687