Fix #5129: Use system-dependent path separator #5130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Sep 20, 2018
| @@ -12,10 +12,10 @@ final case class TestFlags( | |||
| TestFlags(defaultClassPath, runClassPath, options diff flags) | |||
|
|
|||
| def withClasspath(classPath: String): TestFlags = | |||
| TestFlags(s"$defaultClassPath:$classPath", runClassPath, options) | |||
| TestFlags(s"$defaultClassPath${sys.props("path.separator")}$classPath", runClassPath, options) | |||
There was a problem hiding this comment.
Isn't java.io.File.pathSeparator working?
| @@ -54,7 +54,7 @@ trait ParallelTesting extends RunnerOrchestration { self => | |||
| def outDir: JFile | |||
| def flags: TestFlags | |||
|
|
|||
| def runClassPath: String = outDir.getAbsolutePath + ":" + flags.runClassPath | |||
| def runClassPath: String = outDir.getAbsolutePath + java.io.File.pathSeparator + flags.runClassPath | |||
There was a problem hiding this comment.
File is already imported as JFile, please use that.
|
|
||
| def withRunClasspath(classPath: String): TestFlags = | ||
| TestFlags(defaultClassPath, s"$runClassPath:$classPath", options) | ||
| TestFlags(defaultClassPath, s"$runClassPath${java.io.File.pathSeparator}$classPath", options) |
There was a problem hiding this comment.
I’d prefer if you import File here too (maybe as JFile for consistency).
Blaisorblade
suggested changes
Sep 21, 2018
melekhove
changed the title
melekhove
changed the title
|
BTW java.nio.file.NoSuchFileException: ...i4947c\Aux.tasty in the log is the result of the #5148 |
|
@melekhove Merging, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.