New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasty reflect underlying tree #5164

Merged
merged 2 commits into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@nicolasstucki
Copy link
Contributor

nicolasstucki commented Sep 26, 2018

It does the same as underlyingArgument but resolves any local val.

It allows the macro in foo to figure out the value of the paramter that will be passed. In the following two cases the tree Literal(Constant(2)) would be return by the .underlying of the tree of the argument.

foo(2)
val x = 2
foo(x)
@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Sep 26, 2018

Based on #4968

@nicolasstucki nicolasstucki force-pushed the dotty-staging:tasty-reflect-skip-vals branch 4 times, most recently from 21ec2b3 to 15d1f84 Sep 27, 2018

@nicolasstucki nicolasstucki removed the stat:wip label Sep 30, 2018

@nicolasstucki nicolasstucki force-pushed the dotty-staging:tasty-reflect-skip-vals branch 2 times, most recently from 251c605 to 1ac9876 Oct 2, 2018

@nicolasstucki nicolasstucki removed their assignment Oct 2, 2018

@nicolasstucki nicolasstucki requested a review from allanrenucci Oct 2, 2018

@nicolasstucki nicolasstucki changed the title Tasty reflect skip vals Tasty reflect underlying tree Oct 4, 2018

@allanrenucci allanrenucci requested review from OlivierBlanvillain and removed request for allanrenucci Oct 5, 2018

@nicolasstucki nicolasstucki force-pushed the dotty-staging:tasty-reflect-skip-vals branch from 1ac9876 to 280079f Oct 7, 2018

@nicolasstucki nicolasstucki force-pushed the dotty-staging:tasty-reflect-skip-vals branch from 6a172ad to d4c5f90 Oct 16, 2018

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Oct 16, 2018

rebased

@nicolasstucki nicolasstucki force-pushed the dotty-staging:tasty-reflect-skip-vals branch from d4c5f90 to 82b6f95 Oct 22, 2018

@nicolasstucki

This comment has been minimized.

Copy link
Contributor

nicolasstucki commented Oct 22, 2018

rebased

@OlivierBlanvillain
Copy link
Contributor

OlivierBlanvillain left a comment

LGTM

@nicolasstucki nicolasstucki merged commit 5a76013 into lampepfl:master Oct 23, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@nicolasstucki nicolasstucki deleted the dotty-staging:tasty-reflect-skip-vals branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment