Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasty reflect underlying tree #5164

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Tasty reflect underlying tree #5164

merged 2 commits into from
Oct 23, 2018

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Sep 26, 2018 •
edited
Loading

It does the same as underlyingArgument but resolves any local val.

It allows the macro in foo to figure out the value of the paramter that will be passed. In the following two cases the tree Literal(Constant(2)) would be return by the .underlying of the tree of the argument.

foo(2)
val x = 2
foo(x)

@nicolasstucki nicolasstucki self-assigned this Sep 26, 2018
@nicolasstucki
Copy link
Contributor Author

Based on #4968

@nicolasstucki nicolasstucki force-pushed the tasty-reflect-skip-vals branch 4 times, most recently from 21ec2b3 to 15d1f84 Compare September 27, 2018 22:19
@nicolasstucki nicolasstucki force-pushed the tasty-reflect-skip-vals branch 2 times, most recently from 251c605 to 1ac9876 Compare October 2, 2018 15:01
@nicolasstucki nicolasstucki removed their assignment Oct 2, 2018
@nicolasstucki nicolasstucki changed the title Tasty reflect skip vals Tasty reflect underlying tree Oct 4, 2018
@allanrenucci allanrenucci requested review from OlivierBlanvillain and removed request for allanrenucci October 5, 2018 15:02
@nicolasstucki
Copy link
Contributor Author

rebased

@nicolasstucki
Copy link
Contributor Author

rebased

OlivierBlanvillain
OlivierBlanvillain approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 5a76013 into scala:master Oct 23, 2018
@nicolasstucki nicolasstucki deleted the tasty-reflect-skip-vals branch October 23, 2018 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierBlanvillain OlivierBlanvillain OlivierBlanvillain approved these changes

Assignees

@OlivierBlanvillain OlivierBlanvillain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @OlivierBlanvillain @allanrenucci