Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Switch to the 2.13 standard library #7019
Still to do:
As soon as this PR is merged we should publish a new nightly and use it as the reference compiler, so that we don't spend too much time with a build that uses both the 2.12 and 2.13 stdlib (it works, but it can be confusing and cumbersome).
dotty-bot left a comment
Hello, and thank you for opening this PR!
All contributors have signed the CLA, thank you!
We want to keep history, but for that to actually be useful we have
Please stick to these guidelines for commit messages:
Have an awesome day!
@milessabin There's (at least) one compilation error for shapeless on 2.13:
[error] -- [E007] Type Mismatch Error: /home/smarter/opt/dotty/community-build/community-projects/shapeless/core/src/main/scala/shapeless/shapeless.scala:64:51 [error] 64 | WrappedArray.make[String](summonValuesAsArray[mirror.MirroredElemLabels]) [error] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [error] | Found: Array[Any] [error] | Required: Array[String] [error] one error found
If you have the time, it'd be great if you could take a look at it.
@milessabin There's still an error
[error] -- [E007] Type Mismatch Error: /home/smarter/opt/dotty/community-build/community-projects/shapeless/core/src/main/scala/shapeless/shapeless.scala:65:31 [error] 65 | WrappedArray.make[String](summonValuesAsArray[mirror.MirroredElemLabels, String]) [error] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [error] | Found: scala.collection.mutable.ArraySeq[String] [error] | Required: Seq[String]
This can be solved by adding a .toSeq to get an immutable Seq, but there might be a nicer way. Note that you don't necessarily need to keep compiling against both the 2.12 and 2.13 stdlib, I'm happy with a 2.13-only git branch.
Actually we already have a related test that should be updated: https://github.com/lampepfl/dotty/blob/master/tests/run/caseClassHash.scala https://github.com/lampepfl/dotty/blob/master/tests/run/caseClassHash.check
Aug 14, 2019
@liufengyun Unfortunately, https://github.com/liufengyun/bench/tree/master/tests/scala-library does not compile anymore now that the compiler runs using the 2.13 stdlib. I tried to hack it to make it compile, but it seems pretty hard, so I think we'll have to remove it from the benchmarks, and replace it by the new stdlib.