Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-dotty: Use default dependency resolution, release 0.4.1 #8653

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

smarter
Copy link
Member

@smarter smarter commented Apr 2, 2020

@anatoliykmetyuk With drone I was able to release a new sbt-dotty version by running rone build promote lampepfl/dotty NNNN sbt_release, how do I do that with github-release ? (Switching to making a release when a special tag like sbt-dotty-v... is pushed would be fine too)

The option was passed in the wrong place so wasn't actually set most of
the time.
In particular, this should use coursier instead of ivy unless someone
forced the use of ivy. And we shouldn't have to worry about
inter-project dependencies in the dotty build because of
coursier/sbt-coursier#101.
@anatoliykmetyuk anatoliykmetyuk merged commit 8436ed5 into scala:master Apr 3, 2020
@anatoliykmetyuk anatoliykmetyuk deleted the sbt-dotty-coursier branch April 3, 2020 15:32
@anatoliykmetyuk
Copy link
Contributor

anatoliykmetyuk commented Apr 3, 2020

@smarter that command triggered the following command:

  ./project/scripts/sbtPublish ";project sbt-dotty ;publishSigned ;sonatypeBundleRelease"

You can run it locally but you will need to set the following envvars. For PGP_PW/PGP_SECRET you can use your private key.

I think it will be a good idea to make SBT plugins released on tags the same way we release Dotty. E.g. the tag can take the form of sbt_plugin_0.4.1 and this will trigger the plugin publish workflow in GH Actions CI.

@smarter
Copy link
Member Author

smarter commented Apr 3, 2020

You can run it locally but you will need to set the following envvars. For PGP_PW/PGP_SECRET you can use your private key.

I don't want to run it locally. We do all our release via CI to avoid issues with unclean environments, etc, we shouln't stop now. I'll see if the drone ci publish step still works.

I think it will be a good idea to make SBT plugins released on tags the same way we release Dotty. E.g. the tag can take the form of sbt_plugin_0.4.1 and this will trigger the plugin publish workflow in GH Actions CI.

Agreed, can you implement that? (we already have an sbt-dotty-v0.4.0 tag so I would follow this convention).

SethTisue pushed a commit to scala-steward/scala-xml that referenced this pull request Apr 6, 2020
the main change seems to be scala/scala3#8653
SethTisue pushed a commit to scala/scala-xml that referenced this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants