Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9809: enable static fields in Scala.js and change forwarders #9955

Merged
merged 6 commits into from
Oct 13, 2020
Merged

Fix #9809: enable static fields in Scala.js and change forwarders #9955

merged 6 commits into from
Oct 13, 2020

Conversation

bishabosha
Copy link
Member

fixes #9809

@bishabosha bishabosha requested a review from sjrd October 6, 2020 15:45
sjrd
sjrd requested changes Oct 8, 2020
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have a few comments, but overall this looks like the right fixes.

tests/sjs-junit/test/org/scalajs/testsuite/compiler/EnumTestScala3.scala Outdated Show resolved Hide resolved
tests/sjs-junit/test/org/scalajs/testsuite/compiler/EnumTestScala3.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/backend/sjs/JSCodeGen.scala Show resolved Hide resolved
compiler/src/dotty/tools/backend/sjs/JSCodeGen.scala Show resolved Hide resolved
compiler/src/dotty/tools/backend/sjs/JSCodeGen.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/backend/sjs/JSCodeGen.scala Outdated Show resolved Hide resolved
@sjrd sjrd assigned bishabosha and unassigned sjrd Oct 10, 2020
@bishabosha bishabosha requested a review from sjrd October 12, 2020 11:46
@bishabosha bishabosha assigned sjrd and unassigned bishabosha Oct 12, 2020
sjrd
sjrd approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @bishabosha

@bishabosha bishabosha assigned smarter and unassigned sjrd Oct 13, 2020
@sjrd sjrd merged commit 0011538 into scala:master Oct 13, 2020
@sjrd sjrd deleted the fix-9809 branch October 13, 2020 12:19
@ekrich ekrich mentioned this pull request Oct 13, 2020
Closed
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

@sjrd sjrd sjrd approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Problem compiling enum on Scala.js
4 participants
@bishabosha @smarter @sjrd @Kordyjan