Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon discussions with @m8nmueller, we discovered that
race
does not necessarily require nested locking oflisteners (which is the only usage of the nested locks).
Instead the
race
implementation can just re-use the upsteam listener's lock and provide one if not yet existed.With this out, I think we can just remove all the nested locking mechanisms. Should a legitimate need is raised
again in the future, we know that there is a sound and performant design ready.
Progress: