This repository has been archived by the owner on Aug 15, 2023. It is now read-only.
Fix sharing resources #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosyk
suggested changes
Oct 1, 2020
There was a problem hiding this comment.
We didn't capture this in any of our tests. Can we create a simple test for the functions? A simple request with the right status code might be enough - though this possibly means that we have to create a dashboard page in lana and describe it as a test fixture in the tests' README.md.
bosyk
suggested changes
Oct 2, 2020
There was a problem hiding this comment.
The test tests/test_shiny_dashboards.py::TestDashboardAPI::test_shiny_dashboard_management fails. It seems like another tests creates more and dashboards, so that this test finds more than one and raises. Maybe there is some cleaning up after the tests missing?
bosyk
suggested changes
Oct 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for the sharing of dashboards and shiny dashboards.
The endpoint used for sharing was changed to
/api/{resource_id}/sharing.In addition a fix for the
describe_dashboard_items()function was included where a non-existing function was referenced and some doc-strings were updated for accuracy.