This repository has been archived by the owner on Aug 15, 2023. It is now read-only.
Semantic creation functions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… alter the original dataframe
bosyk
suggested changes
Apr 16, 2020
There was a problem hiding this comment.
The test test_upload_event_log_from_df fails at line 92 and the following:
resp = self.api.upload_event_log_df(
'pylana-test-log-from-df', df_log, df_case, time_format='yyyy-MM-dd HH:mm:ss')
self.assertEqual(resp.status_code, 200)which means the method upload_event_log_df is likely broken, assumed that the test expectation hasn't changed.
bosyk
reviewed
Apr 23, 2020
pylana/utils.py
Outdated
Comment on lines
67
to
68
| for i in range(0, len(df.columns)): | ||
| col = df.columns[i] |
There was a problem hiding this comment.
This can be pythonically simplified to
for i, col in enumerate(df.columns):
bosyk
approved these changes
Jun 3, 2020
pylana/utils.py
Outdated
|
|
||
| return df.loc[:, [c['name'] for c in dct_bare]], dct_bare | ||
| dct_bare = [] | ||
| ids = ["Case ID", "Action"] |
There was a problem hiding this comment.
Space character are not nice, since it prevents accessing a data frame atribute lime df.name. Better use CaseID.
There was a problem hiding this comment.
I realised that the issue with the case id naming was purely a lana issue, so I introduced a mapping between a required name for the case id column in python. Thus, we can allow case id names we like, currently Case_ID and CaseID.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create semantics function now only returns the semantics and does not alter the original dataframe