perf: v2 fsl decode perf fix and some benchmarking utilities #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
westonpace
commented
Apr 17, 2024
westonpace
commented
- Add the ability to encode / decode in memory
- Add some initial decoder benchmarks
- Fix a perf bug (extra copy) in the fixed size list decoder
- Add some initial file reader benchmarks
- Add initial tracing to the decode path
- Make batch readahead configurable
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
==========================================
- Coverage 81.15% 81.08% -0.08%
==========================================
Files 185 186 +1
Lines 53508 53533 +25
Branches 53508 53533 +25
==========================================
- Hits 43425 43406 -19
- Misses 7609 7656 +47
+ Partials 2474 2471 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
westonpace
force-pushed
the
chore/file-benches
branch
from
7343049
to
34f2550
Compare
wjones127
approved these changes
Apr 18, 2024
| .col(None, lance_datagen::array::rand_type(&DataType::Int32)) | ||
| .into_batch_rows(lance_datagen::RowCount::from(1024 * 1024)) | ||
| .unwrap(); | ||
| let rt = tokio::runtime::Runtime::new().unwrap(); |
There was a problem hiding this comment.
nit: instead of intializing a runtime inside of a loop, could we move to a static one? Here's an example of using std::sync::OnceLock to accomplish this:
There was a problem hiding this comment.
Done. Though I just moved the runtime creation to the top of the benchmark method (outside the loop) instead of making it static.
* Add the ability to encode / decode in memory * Add some initial decoder benchmarks * Fix a perf bug (extra copy) in the fixed size list decoder * Add some initial file reader benchmarks * Add initial tracing to the decode path * Make batch readahead configurable
westonpace
force-pushed
the
chore/file-benches
branch
from
c45fb2d
to
95afe8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.