feat(java): add version latestVersion api #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
reviewed
Apr 22, 2024
| @@ -127,14 +129,18 @@ public void createDatasetAndValidate() throws IOException, URISyntaxException { | |||
| assertEquals(ROW_COUNT, dataset.countRows()); | |||
| schema = reader.getVectorSchemaRoot().getSchema(); | |||
| validateFragments(dataset); | |||
| assertEquals(1, dataset.version()); | |||
| assertEquals(1, dataset.latestVersion()); | |||
There was a problem hiding this comment.
Do we have tests where version() != latestVersion()?
There was a problem hiding this comment.
Addressed the comment, PTAL
|
@eddyxu PTAL, thanks! |
|
@eddyxu PTAL |
QianZhu
reviewed
Apr 26, 2024
| #[snafu(display("Invalid argument: {}", message))] | ||
| InvalidArgument { message: String }, | ||
| #[snafu(display("Invalid argument: {}, location: {}", message, location))] | ||
| InvalidArgument { message: String, location: Location }, |
There was a problem hiding this comment.
why do we need Location in the error msg?
There was a problem hiding this comment.
this location tells us which line generated the error. This is how we get a "stack trace" when an error happens
QianZhu
approved these changes
Apr 26, 2024
java/core/lance-jni/src/error.rs
Outdated
| @@ -97,6 +97,7 @@ impl From<Utf8Error> for Error { | |||
| fn from(source: Utf8Error) -> Self { | |||
| Self::InvalidArgument { | |||
| message: source.to_string(), | |||
| location: location!(), | |||
There was a problem hiding this comment.
This should use track_caller location instead of the conversion site location.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the example @chebbyChefNEQ ! Addressed the comments, PTAL
chebbyChefNEQ
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.