feat: define IVFShuffler trait #2376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gh/chebbyChefNEQ/1/base #2376 +/- ##
==========================================================
Coverage ? 80.06%
==========================================================
Files ? 199
Lines ? 54469
Branches ? 54469
==========================================================
Hits ? 43613
Misses ? 8341
Partials ? 2515
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eddyxu
reviewed
May 23, 2024
eddyxu
reviewed
May 23, 2024
| pub trait IvfShuffler { | ||
| /// Shuffle the incoming stream of record batches into IVF partitions. | ||
| /// Returns a IvfShuffleReader that can be used to read the shuffled partitions. | ||
| async fn shuffle( |
There was a problem hiding this comment.
Once this function is finished, do we expect that all shuffles are done? Or do we expect Shuffles are in flight, so that IvfShufflerReader might return partial results in read_partition()?
There was a problem hiding this comment.
Once this function finishes, all shuffle should have been completed
eddyxu
reviewed
May 23, 2024
eddyxu
reviewed
May 23, 2024
eddyxu
reviewed
May 23, 2024
eddyxu
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):