Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(node): creating empty table and adding data #757

Closed
changhiskhan opened this issue Dec 31, 2023 · 0 comments
Closed

bug(node): creating empty table and adding data #757

changhiskhan opened this issue Dec 31, 2023 · 0 comments
Assignees
@westonpace
Labels
bug Something isn't working priority: high Issues that are high priority (for LanceDb, the organization) typescript Typescript / javascript

Comments

@changhiskhan
Copy link
Contributor

LanceDB version

v0.3.2

What happened?

  1. We use vectorFromArray in ArrowJS which converts array of numbers into Float64. So if you create an empty table with an Int32 field, there's no way to add data to it (fails due to schema mismatch)
  2. I tried to add code to use a table's existing schema to cast the array. However, it seems that for an empty table, our code doesn't report the schema properly
  3. For LocalTable, there's no Schema interface (not a bug, just API gap)

Are there known steps to reproduce?

No response
@changhiskhan changhiskhan added bug Something isn't working typescript Typescript / javascript labels Dec 31, 2023
@changhiskhan changhiskhan mentioned this issue Dec 31, 2023
Merged
changhiskhan added a commit that referenced this issue Jan 3, 2024
@changhiskhan
feat(js): support list of string input (#755)
684eb8b 
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: #757 #758
koolamusic pushed a commit to tecmie/lancedb that referenced this issue Jan 12, 2024
@changhiskhan @koolamusic
feat(js): support list of string input (lancedb#755)
4417f7c 
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: lancedb#757 lancedb#758
@westonpace westonpace added the priority: high Issues that are high priority (for LanceDb, the organization) label Jan 29, 2024
@eddyxu eddyxu mentioned this issue Jan 29, 2024
Open
@westonpace westonpace assigned westonpace and unassigned eddyxu Jan 31, 2024
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this issue Apr 5, 2024
@changhiskhan
feat(js): support list of string input (lancedb#755)
0107c8d 
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: lancedb#757 lancedb#758
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this issue Apr 5, 2024
@changhiskhan @koolamusic
feat(js): support list of string input (lancedb#755)
4814499 
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: lancedb#757 lancedb#758
westonpace pushed a commit that referenced this issue Apr 5, 2024
@changhiskhan @westonpace
feat(js): support list of string input (#755)
cd791a3 
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: #757 #758
westonpace pushed a commit that referenced this issue Apr 5, 2024
@changhiskhan @westonpace
feat(js): support list of string input (#755)
81487f1 
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: #757 #758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonpace westonpace

Labels
bug Something isn't working priority: high Issues that are high priority (for LanceDb, the organization) typescript Typescript / javascript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eddyxu @changhiskhan @westonpace