Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(node): list of number input causes panic #758

Closed
Tracked by #1251
changhiskhan opened this issue Dec 31, 2023 · 3 comments
Closed
Tracked by #1251

bug(node): list of number input causes panic #758

changhiskhan opened this issue Dec 31, 2023 · 3 comments
Labels
bug Something isn't working typescript Typescript / javascript

Comments

@changhiskhan
Copy link
Contributor

LanceDB version

No response

What happened?

repro:

const data = [
  { id: 1, vector: [0.1, 0.2], list_of_num: [1,2,3] },
  { id: 2, vector: [1.1, 1.2], list_of_num: [4, 5] }
]
const table = await con.createTable("myTable", data)

error:

     Error: internal error in Neon module: called `Option::unwrap()` on a `None` value

Are there known steps to reproduce?

No response

@changhiskhan changhiskhan added bug Something isn't working typescript Typescript / javascript labels Dec 31, 2023
changhiskhan added a commit that referenced this issue Jan 3, 2024
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: #757 #758
koolamusic pushed a commit to tecmie/lancedb that referenced this issue Jan 12, 2024
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: lancedb#757 lancedb#758
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this issue Apr 5, 2024
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: lancedb#757 lancedb#758
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this issue Apr 5, 2024
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: lancedb#757 lancedb#758
westonpace pushed a commit that referenced this issue Apr 5, 2024
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: #757 #758
westonpace pushed a commit that referenced this issue Apr 5, 2024
Add support for adding lists of string input (e.g., list of categorical
labels)

Follow-up items: #757 #758
@universalmind303
Copy link
Contributor

universalmind303 commented Apr 29, 2024

this doesn't seem to be an issue on 0.4.16 of vectordb or @lancedb/lancedb

vectordb

import * as lancedb from "vectordb";
const uri = "data/sample-lancedb";
const db = await lancedb.connect(uri);
const data = [
  { id: 1, vector: [0.1, 0.2], list_of_num: [1,2,3] },
  { id: 2, vector: [1.1, 1.2], list_of_num: [4, 5] }
]
const table = await db.createTable("myTable", data)
console.log(table);

lancedb

import * as lancedb from "@lancedb/lancedb";
const uri = "data/sample-lancedb";
const db = await lancedb.connect(uri);
const data = [
  { id: 1, vector: [0.1, 0.2], list_of_num: [1,2,3] },
  { id: 2, vector: [1.1, 1.2], list_of_num: [4, 5] }
]
const table = await db.createTable("myTable", data)
console.log(table.display());

@universalmind303
Copy link
Contributor

@changhiskhan are you able to provide a minimum reproducible example?

@wjones127
Copy link
Contributor

If we aren't able to reproduce anymore, I think it's fine to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working typescript Typescript / javascript
Projects
None yet
Development

No branches or pull requests

3 participants