Add cohere embedding function #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,7 @@ | |||
| # limitations under the License. | |||
|
|
|||
|
|
|||
| from .cohere import CohereEmbeddingFunction | |||
There was a problem hiding this comment.
is it worth separating out the existing embedding functions into their own modules? e.g., openai.py, openclip.py, sentence_transformers.py?
There was a problem hiding this comment.
yeah I think so. The scope and size of the file functions.py will become too large otherwise.
python/lancedb/embeddings/cohere.py
Outdated
|
|
||
| def ndims(self): | ||
| if self._ndims is None: | ||
| self._ndims = len(self.generate_embeddings(["foo"])[0]) |
There was a problem hiding this comment.
this requires a remote api call which is a bit unfortunate. Can we just hard code it for now like we do with openai?
There was a problem hiding this comment.
Done. But what does this accomplish tho? If a user uses a different model, won't hardcoding error out?
changhiskhan
approved these changes
Oct 13, 2023
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
westonpace
pushed a commit
that referenced
this pull request
Apr 5, 2024
alexkohler
pushed a commit
to alexkohler/lancedb
that referenced
this pull request
Apr 20, 2024
build all features Co-authored-by: Chang She <759245+changhiskhan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.