docs: Add meta tag for image preview #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changhiskhan
approved these changes
Feb 19, 2024
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
I think this should work. Need to deploy it to be sure as it can be tested locally. Can be tested here. 2 things about this solution: * All pages have a same meta tag, i.e, lancedb banner * If needed, we can automatically use the first image of each page and generate meta tags using the ultralytics mkdocs plugin that we did for this purpose - https://github.com/ultralytics/mkdocs
westonpace
pushed a commit
that referenced
this pull request
Apr 5, 2024
I think this should work. Need to deploy it to be sure as it can be tested locally. Can be tested here. 2 things about this solution: * All pages have a same meta tag, i.e, lancedb banner * If needed, we can automatically use the first image of each page and generate meta tags using the ultralytics mkdocs plugin that we did for this purpose - https://github.com/ultralytics/mkdocs
alexkohler
pushed a commit
to alexkohler/lancedb
that referenced
this pull request
Apr 20, 2024
alexkohler
pushed a commit
to alexkohler/lancedb
that referenced
this pull request
Apr 20, 2024
…#983) * [WIP] [rust] Added support for minus operator for numeric literals * feat: add feature flags to the dataset manifest (lancedb#979) * wip: implement feature flags * test it * format better * fix test * Use log and allow users to customize log via LANCE_LOG env (lancedb#987) * Benchmark of IVF_PQ index creation (lancedb#988) * [Rust] Reduce arrow overhead during kmean training (lancedb#990) * Added support for minus unary operator and type coercion for binary expressions during expression resolution * Zero copy during kmean membership computation (lancedb#992) * Lint codebase with clippy, isort, black, ruff, and doctest (lancedb#986) * feat: add feature flags to the dataset manifest (lancedb#979) * wip: implement feature flags * test it * format better * fix test * Benchmark of IVF_PQ index creation (lancedb#988) * [Rust] Reduce arrow overhead during kmean training (lancedb#990) * Added tests for negative expressions and formatted code in both rust and python packages --------- Co-authored-by: Will Jones <willjones127@gmail.com> Co-authored-by: Lei Xu <lei@lancedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should work. Need to deploy it to be sure as it cant be tested locally. Can be tested here.
2 things about this solution: