Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ModelGrid.map_link_vector_to_nodes #1815

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

mcflugen
Copy link
Member

@mcflugen mcflugen commented Nov 15, 2023

Description

This pull request addresses #1786 by removing the broken method ModelGrid.map_link_vector_to_nodes. I've also updated Landlab's index file of grids, components, and fields so that the function doesn't appear there (in doing this I also made a few small modifications to our indexing utility).

Checklist - did you ...

  • Add a news fragment file entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?
  • All tests have passed?
  • Formatted code with black?
  • Removed lint reported by flake8?
  • Sucessful documentation built? (if documentation added or modified)

@coveralls
Copy link

coveralls commented Nov 15, 2023

Coverage Status

coverage: 85.491% (-0.03%) from 85.518%
when pulling 975606d on mcflugen/remove-map_link_vector_to_nodes
into ac7592d on master.

@mcflugen mcflugen merged commit 5d7e375 into master Nov 16, 2023
42 checks passed
@mcflugen mcflugen deleted the mcflugen/remove-map_link_vector_to_nodes branch November 16, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants