Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra tests for PHP versions, xdebug and defaults #98

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

rubenvarela
Copy link
Collaborator

@rubenvarela rubenvarela commented Apr 18, 2024

Closes #97

Depends on #89 which contains the linting fix, and the new 8.2 default version.

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs) (thanks to @reynoldsalec)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for lando-acquia ready!

Name Link
🔨 Latest commit 29c32d6
🔍 Latest deploy log https://app.netlify.com/sites/lando-acquia/deploys/662176af94398a00081b551c
😎 Deploy Preview https://deploy-preview-98--lando-acquia.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Sponsor Member

@reynoldsalec reynoldsalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be overkill to do ALL the PHP versions as separate example directories/tests (if we wanted to we could combine them in a single example directory), but I'm ok with this as-is.

@reynoldsalec reynoldsalec merged commit c2d4604 into main Apr 19, 2024
20 checks passed
@reynoldsalec reynoldsalec deleted the feature-testing-php_versions branch April 19, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PHP tests
3 participants