Add support for node 14 and 16, mark older versions legacy

[badrange]

Here is the corresponding documentation PR:
lando/lando#3219

[reynoldsalec]

Thanks @badrange for the contribution! Two things to round out this work:

• add an example for node16 (copying over the node14 example and replacing the relevant versions should work).
• make sure the "patch version" service in the node14 example grabs a legitimate docker hub image (I get the error ERROR: manifest for node:14.18.3 not found: manifest unknown: manifest unknown when trying to pull node:14.18.3.)

@pirog, how should we handle legacy node version support going forward? Should we keep the node10/12 examples, maybe combine them into a node-legacy example?

[reynoldsalec]

I don't think this actually exists.

[badrange]

Ouch, you're quite right about that, should be fixed now.

[badrange]

Thank you for the quick response @reynoldsalec - should be fixed now. I also took the liberty of upgrading the dependencies in the new package.jsons.

[reynoldsalec]

Thanks @badrange, I can spin up node14 now.

When I try to test node16 I'm getting a message ERROR ==> node version 16.13.0 is not supported; you'll need to add 16.13 to the supportedVersions array in the node/builder.js.

You'll also want to all your tests to the .github/workflows/pr-node-tests.yml file under the leia-tests section; you use the title of the README file there.

[badrange]

Thanks for the feedback @reynoldsalec - I now managed to get the tests to pass.

[reynoldsalec]

Spoke with Pirog and he wants us to keep all the legacy version options available/tested. Let's keep the node-10-example tests @badrange

[badrange]

Ah, makes sense! I pushed an update, let's hope the CI/CD pipeline works.

[reynoldsalec]

You're a champ @badrange, I'm going to merge this in.

Would you have interest in maintaining the node recipe once we split it out of Lando core? Might be up your alley...

[badrange]

Happy times!

Let's get back with maintainership once that happens, depends on the work situation you know! :-)