Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.20.2] WSL2 Could not detect docker-compose v2.21.0! Downloading it #67

Closed
eldair opened this issue Oct 3, 2023 · 11 comments · Fixed by #68
Closed

[v3.20.2] WSL2 Could not detect docker-compose v2.21.0! Downloading it #67

eldair opened this issue Oct 3, 2023 · 11 comments · Fixed by #68
Assignees
Labels
bug Something isn't working

Comments

@eldair
Copy link

eldair commented Oct 3, 2023

Hello,

I'm using lando in wsl 2 with docker desktop installed on windows 11.

Latest lando version cannot detect that docker-compose is available and instead is trying to download it:
"Could not detect docker-compose v2.21.0! Downloading it"

image

Everything was working fine in previous version.

@eldair eldair added the bug Something isn't working label Oct 3, 2023
@pirog
Copy link
Sponsor Member

pirog commented Oct 3, 2023

@eldair this is expected. just let it download it.

@pirog pirog removed the bug Something isn't working label Oct 3, 2023
@eldair
Copy link
Author

eldair commented Oct 3, 2023

I did and it works, but what happened with that downloaded file? Is it deleted now or?

@pirog
Copy link
Sponsor Member

pirog commented Oct 3, 2023

it should be in ~/.lando/bin and it is what lando will use for docker compose.

@web-assistant
Copy link

web-assistant commented Oct 3, 2023

I get this message every single time I run a lando command

Could not detect docker-compose v2.21.0! Downloading it...

~/.lando/bin seems empty

I'm using lando via hyper-v on Windows 10

@pirog
Copy link
Sponsor Member

pirog commented Oct 3, 2023

@web-assistant run it in verbose mode with -vvv there should be relevant output about what is happening. If that message is showing up every time then its not downloading it correctly for whatever reason.

If it fails it will try to use a system-installed version of docker-compose if that is available. See https://docs.lando.dev/core/v3/orchestrator.html for more details

for reference this is what the verbose output looks like for me

lando 10:53:34 DEBUG ==> could not detect docker-compose v2.21.0!
lando 10:53:35 DEBUG ==> downloading https://github.com/docker/compose/releases/download/v2.21.0/docker-compose-darwin-aarch64 to /Users/pirog/.lando/bin/docker-compose-v2.21.0...
lando 10:53:49 DEBUG ==> /var/folders/5y/f7msllhx3x78sk2f1q07f34c0000gn/T/z52gCArLe9NQ4vmNn_05P returned Docker Compose version v2.21.0
lando 10:53:50 DEBUG ==> docker-compose v2.21.0 downloaded to /Users/pirog/.lando/bin/docker-compose-v2.21.0
lando 10:53:50 DEBUG ==> using docker-compose 2.21.0 located at /Users/pirog/.lando/bin/docker-compose-v2.21.0
lando 10:53:50 DEBUG ==> using docker-compose /Users/pirog/.lando/bin/docker-compose-v2.21.0

@web-assistant
Copy link

@pirog running -vvv outputs...

lando 15:58:55 DEBUG ==> could not detect docker-compose v2.21.0!
lando 15:58:56 DEBUG ==> downloading https://github.com/docker/compose/releases/download/v2.21.0/docker-compose-windows-x86_64.exe to C:\Users\webassistnt_000.lando\bi
n\docker-compose-v2.21.0...
lando 15:59:17 DEBUG ==> could not download docker-compose v2.21.0: Cannot read properties of null (reading 'toString')

@pirog
Copy link
Sponsor Member

pirog commented Oct 3, 2023

got it. that seems like a legit bug then. not sure why that is happening in your situation but is something we can guard against at least.

in the meantime i would manually download it and place it at C:\Users\webassistnt_000.lando\bi n\docker-compose-v2.21.0 which should at least get you going.

You may need to either remove the .exe from the filename or set the following in your global lando config.yml

orchestratorBin: C:\Users\webassistnt_000.lando\bin\docker-compose-v2.21.0.exe

@pirog pirog transferred this issue from lando/lando Oct 3, 2023
@pirog pirog self-assigned this Oct 3, 2023
@pirog pirog added bug Something isn't working and removed Needs Triage labels Oct 3, 2023
@web-assistant
Copy link

@pirog downloading and putting the docker-compose-v2.21.0.exe file into the bin manually has solved the issue for me - I did have to remove the .ext for it to work.

Thank you! 🙂👍

@pirog
Copy link
Sponsor Member

pirog commented Oct 3, 2023

thank you for helping us track down a pretty bad bug!

@bryanbuchs
Copy link

Same issue here, was able to correct by setting my user account's .lando/config.yml to:

orchestratorBin: 'C:\Program Files\Docker\Docker\resources\bin\docker-compose'

reynoldsalec added a commit that referenced this issue Oct 3, 2023
reynoldsalec added a commit that referenced this issue Oct 3, 2023
@reynoldsalec
Copy link
Sponsor Member

...fix for this should be in the next 3.20.x release: #68

@pirog pirog linked a pull request Oct 6, 2023 that will close this issue
pirog added a commit that referenced this issue Oct 6, 2023
@pirog pirog closed this as completed in #68 Oct 6, 2023
pirog added a commit that referenced this issue Oct 6, 2023
* #67: Fix location of docker compose 2 and decouple Docker Desktop version detection from DC2 location.

* #67: Feed the linter.

* #67: changelog

* make keyname matrix unique

* make keyname matrix unique part 2

* make keyname matrix unique part 3

---------

Co-authored-by: Mike Pirog <mike@lando.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants