Add node service to lando-lagoon #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
鉁旓笍 Deploy Preview for lando-lagoon ready! 馃敤 Explore the source changes: 557896f 馃攳 Inspect the deploy log: https://app.netlify.com/sites/lando-lagoon/deploys/61a9b0ed11d27e0007f8a6a8 馃槑 Browse the preview: https://deploy-preview-15--lando-lagoon.netlify.app |
|
#44 completes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a Node service to the Lagoon integration.
It is still marked as draft because the
otherServingContainersfunc is hardcoded to port 8080 (which works for Varnish, but not Node (3000) or Python (8800) - so that routine will need modifying to support multiple proxy ports. To get around this, I've created a standalone func for Node. In the medium-term, Lagoon will be making these ports configurable, so Lando will need a way to be told what port to use per service via the docker-compose.yamlI also think I've managed to set my local dev up properly to work on this as a plugin/integration, but 馃し