New Lagoon/Lando Services #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for lando-lagoon pending review.Visit the deploys page to approve it
|
|
to-do - add an example with these services to the repo |
Comment on lines
+43
to
+49
| - name: Find and Replace | ||
| uses: jacobtomlinson/gha-find-replace@v3 | ||
| with: | ||
| find: "lagoon/lagoon" | ||
| replace: ${{ github.event.repository.name }}/${{ github.event.repository.name }} | ||
| include: "actions-lando-config.yml" | ||
| regex: false |
There was a problem hiding this comment.
quick note here - we needed to replace the lando-config here, as our fork of the repo isn't in a lagoon repo - so this allows the config to pick up the correct repo name
|
This looks good to me, the only comment I had was making sure the If @CGoodwin90 or @tobybellwood could merge that in here, let's deploy this thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates the new services for Node, Ruby and Python.