Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing errors when Pantheon D7 site is using PHP 5.3 [bug fix] #328

Closed
mel-miller opened this issue Sep 6, 2017 · 2 comments
Closed
Assignees
Labels
bug Something aint working right!
Milestone

Comments

@mel-miller
Copy link

Which leads me to the following question: Does Lando require apps to be running a minimum PHP version?

I'm new to Lando and was getting the following error when trying to pull existing sites from Pantheon. I get this at the end of 'lando start'

     [success]
/bin/sh: 1: terminus: not found
error:  message=/bin/sh: 1: terminus: not found
, code=127

We are still running PHP 5.3 on sites in our D7 distro. So I decided to test a few other scenarios -- both D7 with PHP 5.6 and D8 with PHP 7.0 seem to work fine -- again I'm new to Lando, but I didn't get error and was able to navigate to those sites.

Bug Report

OSX 10.12.6
Lando 3.0.0-beta.13

Does this bug prevent you from using lando?
Yes!

Lando

name: ep-osu
recipe: pantheon
config:
  framework: drupal
  env: dev
  site: ep-osu
  id: 0c5c2c6d-d3f8-4280-9050-84a019ff0e73

Pantheon

api_version: 1

php_version: 5.3

drush_version: 7

workflows:
  deploy:
    after:
        - type: webphp
          description: Post to Slack after deploy
          script: private/scripts/slack_notification.php

Verbose output of lando start is in attached file.
lando-start.txt

@mel-miller mel-miller changed the title Throwing errors when Pantheon D7 site is using PHP 5.3 Throwing errors when Pantheon D7 site is using PHP 5.3 [bug fix] Sep 7, 2017
@pirog
Copy link
Sponsor Member

pirog commented Sep 10, 2017

@miller2676 yeah this doesn't surprise me. i think the issue here is terminus requires php 5.5+ so its problematic to run it in the 5.3 appserver. that said im going to implement #160 as a way to get around this for now.

thanks for posting this.

@pirog pirog self-assigned this Sep 10, 2017
@pirog pirog added the bug Something aint working right! label Sep 10, 2017
@pirog pirog added this to the 3.0.0-rc.1 milestone Sep 10, 2017
pirog added a commit that referenced this issue Sep 10, 2017
pirog added a commit that referenced this issue Sep 10, 2017
@pirog pirog closed this as completed Sep 10, 2017
pirog added a commit that referenced this issue Sep 10, 2017
pirog added a commit that referenced this issue Sep 10, 2017
@mel-miller
Copy link
Author

This absolutely did the trick. Thanks @pirog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something aint working right!
Projects
None yet
Development

No branches or pull requests

2 participants