Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needed support for PHP 8.2 #159

Closed
tyllyn opened this issue Mar 8, 2023 · 4 comments
Closed

Needed support for PHP 8.2 #159

tyllyn opened this issue Mar 8, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@tyllyn
Copy link

tyllyn commented Mar 8, 2023

Began work locally on upgrading a Pantheon Drupal site to PHP 8.2, and adjusted the pantheon.yml as such:

api_version: 1
php_version: 8.2`

Upon attempting to rebuild with lando rebuild, I receive the following console output:

? Are you sure you want to rebuild? Yes
Rising anew like a fire phoenix from the ashes! Rebuilding app...
No stopped containers
Pulling appserver ... error
Pulling cache     ... done
Pulling database  ... done
Pulling edge      ... done
Pulling index     ... done

ERROR: for appserver  manifest for devwithlando/pantheon-appserver:8.2-2 not found: manifest unknown: manifest unknown
ERROR: manifest for devwithlando/pantheon-appserver:8.2-2 not found: manifest unknown: manifest unknown
ERROR ==>
@tyllyn tyllyn added the bug Something isn't working label Mar 8, 2023
reynoldsalec added a commit to ossobuffo/pantheon that referenced this issue Mar 16, 2023
@reynoldsalec
lando#159: Add 8.2 to gen4 array and update CHANGELOG.
0174326
@reynoldsalec
Copy link
Sponsor Member

Reviewing #161 by @ossobuffo, should have this merged in shortly.

reynoldsalec added a commit that referenced this issue Mar 16, 2023
@reynoldsalec
#159: Generate 8.2 images on Docker Hub.
d96f0fc
reynoldsalec added a commit that referenced this issue Mar 16, 2023
@reynoldsalec @ossobuffo
8.2 support lando (#162)
0cda2a4 
* Add PHP 8.2 support

* #159: Add 8.2 to gen4 array and update CHANGELOG.

* Try apt-get update before apparmor install.

* Add Reading package lists... for apparmor to all tests.

* #159: Generate 8.2 images on Docker Hub.

---------

Co-authored-by: Daniel Johnson <djohnson@webfirst.com>
reynoldsalec added a commit that referenced this issue Mar 20, 2023
@reynoldsalec
#159: Update Terminus version for PHP 8.2 compatibility.
b5f2579
@sharique
Copy link

sharique commented Apr 5, 2023

How to update pantheon recipe to get PHP 8.2 support?

@reynoldsalec
Copy link
Sponsor Member

8.2 support was added in v0.10.0 of this plugin, and should be packaged with any Lando install from v3.17.0 onwards.

@reynoldsalec
Copy link
Sponsor Member

FYI, note that the correct way to use different PHP versions with the Pantheon recipe is to specify the version of PHP in your pantheon.yml...IE if you have PHP defined there, Lando should respect that (although you'll probably need to run a lando rebuild for it to take effect).

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sharique @tyllyn @reynoldsalec