Fix PHP Image Build Matrix #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for lando-php failed.
|
reynoldsalec
force-pushed
the
98-build-php-images
branch
from
21fd6b4
to
b6b92b5
Compare
|
One minor thing: if we need to remove imagick from the 8.3 images, then the docs/extensions.md should also reflect that change. The X marking should be removed from the 8.3 column in the imagick row in the table of Installed Extensions. |
|
Thanks for reminding me @kaszarobert; just did that! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98. Underlying problem is an issue generating the build matrix; for some reason the lando-version value is creating a single build item, the build for
7.3-apache-4, which is the bottom most build in theincludesmatrix item.This PR "fixes" the problem by hardcoding 3-dev-slim as the Lando version to use in testing the PHP images.