refactor(attributes): overhaul internals #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lanej
commented
Jun 29, 2016
•
lanej
commented
- simplify strings vs symbols
- remove dead code paths
- verify inheritance support
- bring transforms, parsers definitions into the inherited scope (allow for client-level refinements, isolate transform parser additions). Would be nice to add an API for this.
- reduce method complexity
and use #public_send for access
check before adding anything else
moving transforms, parsers, default_parser down into the mixin allows non-global transforms and overrides to be specified. This would allow two cistern clients to live together with an additional matching transform of a different implementation.
lanej
changed the title
lanej
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.