Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Allow users to pass additional arguments to the WebDriver #4120

Closed
meta-boy opened this issue May 4, 2023 · 0 comments · Fixed by #4121
Closed

[Feature Request] Allow users to pass additional arguments to the WebDriver #4120

meta-boy opened this issue May 4, 2023 · 0 comments · Fixed by #4121

Comments

@meta-boy
Copy link
Contributor

meta-boy commented May 4, 2023 •
edited
Loading

Description:
Currently, when creating a Chrome or Firefox web driver using the selenium.webdriver module, users can only pass a limited set of arguments such as headless mode and hardcoded no-sandbox. However, there are many additional options available for these browsers that cannot be passed in using the existing API. I personally was limited by this when I had to add the --disable-dev-shm-usage and --disable-gpu arguments to the Chrome WebDeriver.

To address this limitation, I propose adding a new arguments parameter to the SeleniumURLLoader that allows users to pass additional arguments as a list of strings.
@meta-boy meta-boy mentioned this issue May 4, 2023
Merged
dev2049 pushed a commit that referenced this issue May 5, 2023
@meta-boy
feat: Allow users to pass additional arguments to the WebDriver (#4121)
19e28d8 
This commit adds support for passing additional arguments to the
`SeleniumURLLoader ` when creating Chrome or Firefox web drivers.
Previously, only a few arguments such as `headless` could be passed in.
With this change, users can pass any additional arguments they need as a
list of strings using the `arguments` parameter.

The `arguments` parameter allows users to configure the driver with any
options that are available for that particular browser. For example,
users can now pass custom `user_agent` strings or `proxy` settings using
this parameter.

This change also includes updated documentation and type hints to
reflect the new `arguments` parameter and its usage.

fixes #4120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow users to pass additional arguments to the WebDriver meta-boy/langchain
1 participant
@meta-boy