feat: Allow users to pass additional arguments to the WebDriver #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for passing additional arguments to the `WebDriver` when creating Chrome or Firefox web drivers. Previously, only a few arguments such as `headless` mode and `executable_path` could be passed in. With this change, users can pass any additional arguments they need as a list of strings using the `arguments` parameter. The `arguments` parameter allows users to configure the driver with any options that are available for that particular browser. For example, users can now pass custom `user_agent` strings or `proxy` settings using this parameter. This change also includes updated documentation and type hints to reflect the new `arguments` parameter and its usage.
hwchase17
added
the
lgtm
pranjaldoshi96
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for passing additional arguments to the
SeleniumURLLoaderwhen creating Chrome or Firefox web drivers. Previously, only a few arguments such asheadlesscould be passed in. With this change, users can pass any additional arguments they need as a list of strings using theargumentsparameter.The
argumentsparameter allows users to configure the driver with any options that are available for that particular browser. For example, users can now pass customuser_agentstrings orproxysettings using this parameter.This change also includes updated documentation and type hints to reflect the new
argumentsparameter and its usage.fixes #4120