-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CometLLM integration notebook example #14650
Conversation
I also added LANGCHAIN_COMET_TRACING to enable the CometLLM tracing integration similar to other tracing integrations. This is easier for end-users to enable it rather than importing the callback and pass it manually.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, needs some lint fix tho
@hwchase17 I'm not sure where the lint error comes from: https://github.com/langchain-ai/langchain/actions/runs/7194744376/job/19595915961 When running the same command on the last commit on that branch, I get many errors but not on the files I touched: Output of make lint_package
Looking at the commit that was checkout for this failing job, it seems to be an old merge commit that's not part of the branch anymore: 6311c05 I'm not sure what happened here, could you try rerunning the failing job? |
I ended up creating a new PR from a new branch and it looks like the tests are passing now #15765 |
I also added LANGCHAIN_COMET_TRACING to enable the CometLLM tracing integration similar to other tracing integrations. This is easier for end-users to enable it rather than importing the callback and pass it manually. (This is the same content as #14650 but rebased and squashed as something seems to confuse Github Action).
I also added LANGCHAIN_COMET_TRACING to enable the CometLLM tracing integration similar to other tracing integrations. This is easier for end-users to enable it rather than importing the callback and pass it manually.