Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: compatibility with SQLAlchemy 1.4.x #17954

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

Davidkloving
Copy link
Contributor

Description:
Change type hint on QuerySQLDataBaseTool to be compatible with SQLAlchemy v1.4.x.

Issue:
Users locked to SQLAlchemy < 2.x are unable to import QuerySQLDataBaseTool.

closes #17819

Dependencies:
None

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 22, 2024
Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 5:53pm

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Feb 22, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 22, 2024
@eyurtsev eyurtsev self-assigned this Feb 22, 2024
@eyurtsev
Copy link
Collaborator

merge when unit tests pass

@eyurtsev eyurtsev changed the title community: compatibility with SQLAlchemy 1.4.x community[patch]: compatibility with SQLAlchemy 1.4.x Feb 22, 2024
@eyurtsev eyurtsev merged commit d068e8e into langchain-ai:master Feb 22, 2024
56 of 58 checks passed
@Davidkloving Davidkloving deleted the patch-1 branch February 22, 2024 20:45
k8si pushed a commit to Mozilla-Ocho/langchain that referenced this pull request Feb 22, 2024
…7954)

**Description:**
Change type hint on `QuerySQLDataBaseTool` to be compatible with
SQLAlchemy v1.4.x.

**Issue:**
Users locked to `SQLAlchemy < 2.x` are unable to import
`QuerySQLDataBaseTool`.

closes langchain-ai#17819

**Dependencies:**
None
al1p pushed a commit to al1p/langchain that referenced this pull request Feb 27, 2024
…7954)

**Description:**
Change type hint on `QuerySQLDataBaseTool` to be compatible with
SQLAlchemy v1.4.x.

**Issue:**
Users locked to `SQLAlchemy < 2.x` are unable to import
`QuerySQLDataBaseTool`.

closes langchain-ai#17819

**Dependencies:**
None
haydeniw pushed a commit to haydeniw/langchain that referenced this pull request Feb 27, 2024
…7954)

**Description:**
Change type hint on `QuerySQLDataBaseTool` to be compatible with
SQLAlchemy v1.4.x.

**Issue:**
Users locked to `SQLAlchemy < 2.x` are unable to import
`QuerySQLDataBaseTool`.

closes langchain-ai#17819

**Dependencies:**
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: 'type' object is not subscriptable when importing Agent
2 participants