-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community[patch]: compatibility with SQLAlchemy 1.4.x #17954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Feb 22, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
Medium size change to existing code to handle new use-cases
label
Feb 22, 2024
4 tasks
eyurtsev
approved these changes
Feb 22, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Feb 22, 2024
merge when unit tests pass |
eyurtsev
changed the title
community: compatibility with SQLAlchemy 1.4.x
community[patch]: compatibility with SQLAlchemy 1.4.x
Feb 22, 2024
k8si
pushed a commit
to Mozilla-Ocho/langchain
that referenced
this pull request
Feb 22, 2024
…7954) **Description:** Change type hint on `QuerySQLDataBaseTool` to be compatible with SQLAlchemy v1.4.x. **Issue:** Users locked to `SQLAlchemy < 2.x` are unable to import `QuerySQLDataBaseTool`. closes langchain-ai#17819 **Dependencies:** None
al1p
pushed a commit
to al1p/langchain
that referenced
this pull request
Feb 27, 2024
…7954) **Description:** Change type hint on `QuerySQLDataBaseTool` to be compatible with SQLAlchemy v1.4.x. **Issue:** Users locked to `SQLAlchemy < 2.x` are unable to import `QuerySQLDataBaseTool`. closes langchain-ai#17819 **Dependencies:** None
haydeniw
pushed a commit
to haydeniw/langchain
that referenced
this pull request
Feb 27, 2024
…7954) **Description:** Change type hint on `QuerySQLDataBaseTool` to be compatible with SQLAlchemy v1.4.x. **Issue:** Users locked to `SQLAlchemy < 2.x` are unable to import `QuerySQLDataBaseTool`. closes langchain-ai#17819 **Dependencies:** None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:improvement
Medium size change to existing code to handle new use-cases
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change type hint on
QuerySQLDataBaseTool
to be compatible with SQLAlchemy v1.4.x.Issue:
Users locked to
SQLAlchemy < 2.x
are unable to importQuerySQLDataBaseTool
.closes #17819
Dependencies:
None