Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added providers page for Pebblo and docs for PebbloRetrievalQA #20746

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

Raj725
Copy link
Contributor

@Raj725 Raj725 commented Apr 22, 2024

  • Description: Added providers page for Pebblo and docs for PebbloRetrievalQA
  • Issue: NA
  • Dependencies: None
  • Unit tests: NA

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 8:18am

@Raj725 Raj725 force-pushed the pebblo_retrieval_chain_docs branch 2 times, most recently from 9444bfb to f5b3634 Compare May 9, 2024 14:17
@Raj725 Raj725 force-pushed the pebblo_retrieval_chain_docs branch from f5b3634 to a049aad Compare May 10, 2024 18:16
eyurtsev added a commit that referenced this pull request May 15, 2024
…c Enforcement support (#20641)

- **Description:** PebbloRetrievalQA chain introduces identity
enforcement using vector-db metadata filtering
- **Dependencies:** None
- **Issue:** None
- **Documentation:** Adding documentation for PebbloRetrievalQA chain in
a separate PR(#20746)
- **Unit tests:** New unit-tests added

---------

Co-authored-by: Eugene Yurtsev <eugene@langchain.dev>
@Raj725 Raj725 force-pushed the pebblo_retrieval_chain_docs branch from a049aad to 93295fa Compare May 16, 2024 04:49
@Raj725 Raj725 force-pushed the pebblo_retrieval_chain_docs branch from 93295fa to a4e91ad Compare May 17, 2024 16:19
@Raj725 Raj725 force-pushed the pebblo_retrieval_chain_docs branch from a4e91ad to e015145 Compare May 20, 2024 14:44
@Raj725 Raj725 force-pushed the pebblo_retrieval_chain_docs branch from e015145 to cf5e1c8 Compare May 20, 2024 14:53
@Raj725 Raj725 force-pushed the pebblo_retrieval_chain_docs branch from cf5e1c8 to 734fa6e Compare May 29, 2024 17:41
@Raj725 Raj725 changed the title langchain: Added docs for PebbloRetrievalQA chain docs: Added docs for PebbloRetrievalQA chain May 29, 2024
@Raj725 Raj725 force-pushed the pebblo_retrieval_chain_docs branch from 734fa6e to a2bd828 Compare May 29, 2024 17:44
@Raj725 Raj725 marked this pull request as ready for review May 29, 2024 17:45
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels May 29, 2024
@Raj725
Copy link
Contributor Author

Raj725 commented May 30, 2024

cc: @eyurtsev

@ccurme
Copy link
Collaborator

ccurme commented Jun 18, 2024

Hi, can you move this to the integrations section of the docs? Thanks.

@Raj725
Copy link
Contributor Author

Raj725 commented Jun 19, 2024

Hi, can you move this to the integrations section of the docs? Thanks.

@ccurme Moved, please review.

hinthornw pushed a commit that referenced this pull request Jun 20, 2024
…c Enforcement support (#20641)

- **Description:** PebbloRetrievalQA chain introduces identity
enforcement using vector-db metadata filtering
- **Dependencies:** None
- **Issue:** None
- **Documentation:** Adding documentation for PebbloRetrievalQA chain in
a separate PR(#20746)
- **Unit tests:** New unit-tests added

---------

Co-authored-by: Eugene Yurtsev <eugene@langchain.dev>
@ccurme
Copy link
Collaborator

ccurme commented Jun 22, 2024

Hi @Raj725, instead of putting this in its own folder, I'd recommend making a providers page for Pebblo in providers/. If desired you could make a short intro page to Pebblo and have a sub-page with this document-- see Vectara for an example.

@Raj725
Copy link
Contributor Author

Raj725 commented Jun 24, 2024

Hi @Raj725, instead of putting this in its own folder, I'd recommend making a providers page for Pebblo in providers/. If desired you could make a short intro page to Pebblo and have a sub-page with this document-- see Vectara for an example.

Sure, I will make the changes and let you know. Thanks!

@Raj725 Raj725 force-pushed the pebblo_retrieval_chain_docs branch from 121e5e8 to 75bac79 Compare June 25, 2024 06:25
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 25, 2024
@Raj725 Raj725 changed the title docs: Added docs for PebbloRetrievalQA chain docs: Added providers page for Pebblo and docs for PebbloRetrievalQA Jun 25, 2024
@Raj725
Copy link
Contributor Author

Raj725 commented Jun 25, 2024

Hi @Raj725, instead of putting this in its own folder, I'd recommend making a providers page for Pebblo in providers/. If desired you could make a short intro page to Pebblo and have a sub-page with this document-- see Vectara for an example.

@ccurme Thank you for your feedback. I just wanted to let you know I've updated the PR accordingly. Please review the changes and let me know if any further adjustments are needed.

@srics
Copy link
Contributor

srics commented Jun 25, 2024

Pebblo maintainer here.
@Raj725 contents LGTM, approved

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 25, 2024
@ccurme
Copy link
Collaborator

ccurme commented Jun 25, 2024

Thanks for iterating!

@ccurme ccurme merged commit d3520a7 into langchain-ai:master Jun 25, 2024
13 checks passed
@Raj725 Raj725 deleted the pebblo_retrieval_chain_docs branch June 26, 2024 07:51
hinthornw pushed a commit that referenced this pull request Jul 3, 2024
…20746)

- **Description:** Added providers page for Pebblo and docs for
PebbloRetrievalQA
- **Issue:** NA
- **Dependencies:** None
- **Unit tests**: NA
mandos21 pushed a commit to mandos21/langchain that referenced this pull request Jul 8, 2024
…angchain-ai#20746)

- **Description:** Added providers page for Pebblo and docs for
PebbloRetrievalQA
- **Issue:** NA
- **Dependencies:** None
- **Unit tests**: NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants