feat(0.5): update support for OpenLLM 0.5 #22442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paperspace <29749331+aarnphm@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: paperspace <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: paperspace <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: paperspace <29749331+aarnphm@users.noreply.github.com>
dosubot
bot
added
size:XL
baskaryan
reviewed
Jun 3, 2024
Comment on lines
-126
to
-132
| model_name: Optional[str] = None, | ||
| *, | ||
| model_id: Optional[str] = None, | ||
| server_url: Optional[str] = None, | ||
| server_url: str, | ||
| timeout: int = 30, | ||
| server_type: Literal["grpc", "http"] = "http", | ||
| embedded: bool = True, |
There was a problem hiding this comment.
shoudl we keep around the old args and raise a warning if they're passed in, so that this isn't a breaking change?
There was a problem hiding this comment.
sure I think we can do that.
There was a problem hiding this comment.
oh, this is for the new class OpenLLMAPI, but for OpenLLM we can keep backward compat.
There was a problem hiding this comment.
ah missed the rename :+1
|
@baskaryan since the OpenLLM implementation here won't support |
aarnphm
commented
Jun 4, 2024
aarnphm
commented
Jun 4, 2024
|
bump @baskaryan when you have bandwidth. sorry for the ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the internal wrapper for OpenLLM
Since OpenLLM v0.5 is considered breaking, I have also taken this opportunity to separate the API and local inference component into two separate class:
OpenLLMAPIwill be responsible for handing remote server going forward (async, sync, streaming supported)OpenLLMwill now only for local inference, and only support batching and synchronous generations.Hopefully this would make it a bit more future-proof. In terms of testing, I believe I have tested through some manual workflow and will be include the tests on our end.
updates from #19894, cc @baskaryan