Harrison/ddg #3206
Merged
Harrison/ddg #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) wrapper around `duckduckgo-search` pypi --------- Co-authored-by: Harrison Chase <hw.chase.17@gmail.com> Co-authored-by: Tianyi Pan <60060750+tipani86@users.noreply.github.com> Co-authored-by: Tianyi Pan <tianyi.pan@clobotics.com> Co-authored-by: Adilzhan Ismailov <13088690+aismlv@users.noreply.github.com> Co-authored-by: Justin Flick <Justinjayflick@gmail.com> Co-authored-by: Justin Flick <jflick@homesite.com>
vowelparrot
pushed a commit
that referenced
this pull request
Apr 25, 2023
- duckduckgo was introduced in #3206, but it’s not enabled in load_tools.py yet. - this PR simply enables it in load_tools.py with a straightforward agent call (as described in get_started doc) to verify the functionality. - duckduckgo integration test passed. TODO: - not seeing an agent specific integration. Since I’m still ramping up here, will add it in a following PR. - it looks like DuckDuckGo is using a different naming convention with postfix “-Tool” vs “-Run” comparing with others. The work is straightforward and it is a great way to explore the codebase, so I decided to take the chance to deeply read the codebase and then make the straightforward change in the next PR. :) This is my first PR. Please let me know if there is anything I can improve. Thank you so much! Agent Call with DuckDuckGo instead. <img width="1279" alt="Screenshot 2023-04-22 at 8 44 18 PM" src="https://user-images.githubusercontent.com/62768671/233819592-85932514-46e8-406c-8d52-672ec4161b42.png">
vowelparrot
pushed a commit
that referenced
this pull request
Apr 26, 2023
…t with other classes. (#3548) I found most other search classes are using -Run postfix except DuckDuckGo. It might be good to keep them consistent. (screenshot below) - Updated all places (using big search and following the original PR #3206) - lint and text passed on local - Retested jupyter example. (btw, for anyone who’s not familiar jupyter + virtual env. Here are the steps to run Jupyter in a selected Virtual Env) — screenshot below. ``` reference: https://www.geeksforgeeks.org/using-jupyter-notebook-in-virtual-environment/# - Activate the Virtual Env - ipython kernel install --user —name=<your virtual env name> - In Jupyter, change Kernel. (in menu) ``` Please let me know if this makes sense. I’m new here and still ramping up. I can remove it if this doesn’t help. Thanks so much! reference 1 - Most search classes are using -Run postfix. <img width="708" alt="Screenshot 2023-04-25 at 12 45 56 PM" src="https://user-images.githubusercontent.com/62768671/234387596-86cf69c8-79b7-45ac-87ea-41d6f07db32d.png"> reference 2 - Jupyter example is also verified. <img width="1191" alt="Screenshot 2023-04-25 at 12 39 17 PM" src="https://user-images.githubusercontent.com/62768671/234387759-9b615e44-d3e7-4397-b7cf-72c53784df59.png">
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
Co-authored-by: itai <itai.marks@gmail.com> Co-authored-by: Itai Marks <itaim@users.noreply.github.com> Co-authored-by: Tianyi Pan <60060750+tipani86@users.noreply.github.com> Co-authored-by: Tianyi Pan <tianyi.pan@clobotics.com> Co-authored-by: Adilzhan Ismailov <13088690+aismlv@users.noreply.github.com> Co-authored-by: Justin Flick <Justinjayflick@gmail.com> Co-authored-by: Justin Flick <jflick@homesite.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.